Git test environment consistency#2152
Draft
elovelan wants to merge 2 commits into
Draft
Conversation
Since there are many ways to configure git, use a standard configuration file, so tests always run with consistent settings
The remote test relied on a full repo clone that included all branches, which isn't guaranteed, especially in CI environments and when using repo forks. Use the cloned repo instead, since it will still test the desired functionality but will always have the necessary upstream branch.
Author
|
I'll spin up a Windows VM for testing! |
Author
|
@Byron, this is actually a little bigger than I had anticipated since there's a bit of config manipulation in the Actions workflows. If you like this approach, I'm happy to bring those settings over but I wanted to check with you first! |
Member
|
The test suite unfortunately has never been isolated, and this bites from time to time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing #2151, I ran into a few issues running tests due to:
origin/masterexisting, which is unlikely in a fork scenario, since the common pattern is to setoriginto the fork andupstreamto the primary repo.mainas the default repo branch name andfetch.prune=true. These break some of the tests so it seemed like it might be a good idea to always use a consistent config file.